Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Setup github workflows, lint + format repo, fix unit tests #64

Merged
merged 25 commits into from
Aug 21, 2023
Merged

feat: Setup github workflows, lint + format repo, fix unit tests #64

merged 25 commits into from
Aug 21, 2023

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Aug 21, 2023 •
edited
Loading

Description

  • ci: add build & release workflows from https://github.com/android/nowinandroid (13c20d4)
  • fix(ci): add missing ci-gradle.properties file for build workflow (e70b363)
  • ci: improve build & release workflows (53846a1)
  • feat(spotless): add necessary files for spotless check (6f0c01b)
  • chore(tools): set java distribution to zulu from adoptopenjdk (b5ea692)
  • chore(tools): specify full version for java as asdf can't recognize it (3e13cda)
  • refactor(androidTest): replace wildcard imports with specific imports in CrisisCleanupAppStateTest (7f95149)
  • feat(spotless): remove copyright texts from spotless copyright files as its not needed at the moment (71c08d9)
  • feat(gradle): disable no-wildcard-imports & filename rules in ktlint (aa9d483)
  • chore: add .git-blame-ignore-revs (1da26d1)
  • ci(build): use assembleDemoDebug for build all step (5992ee6)
  • ci(build): increase timeout for build and test jobs (74fb5b3)
  • test(unit): fix coordinatesToTileCoordinates test in TileCoordinatesTest (f2f8ca2)
  • test(unit): fix param in assertUpdatedWrongLocationFlag test in LocationInputDataFlagFormDataTest (81b4945)
  • test(unit): fix issues with AuthenticationViewModelTest (65b69bc)
  • test(unit): skip all tests in AuthenticationViewModelTest as auth flow will have major changes in future (8f42274)
  • test(unit): remove undefined import from AuthenticationViewModelTest (f308463)
  • test(unit): fix missing Locale import in CrisisCleanupAppStateTest (657a04e)
  • test(unit): add missing allowAnalytics option in AuthenticatedViewModelTest (bf4ae0d)
  • ci(build): disable androidTest & androidTest-GMD jobs since packageDemoDebugAndroidTest task is failing (a55f283)
  • style(format): run ./gradlew --init-script gradle/init.gradle.kts --no-configuration-cache spotlessApply to fix spotless lint + format errors in project (01ce3d5)
  • ci(build): split gradle task steps into separate jobs (build, lint, unit-test, spotless-check) (7b06a6d)
  • ci(main): rename build.yml to main.yml, update workflow name (7444017)
  • ci(main): fix unit-test job name (71bf506)
  • ci(main): fix concurrency group name for main workflow (d9e0de7)

Current Behavior

New Behavior

Screenshots

N/A

Related Issue

N/A

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

@deepanchal
ci: add build & release workflows from https://github.com/android/now…
13c20d4 
…inandroid
@deepanchal
fix(ci): add missing ci-gradle.properties file for build workflow
e70b363
@deepanchal
ci: improve build & release workflows
53846a1
@deepanchal
feat(spotless): add necessary files for spotless check
6f0c01b
@deepanchal
chore(tools): set java distribution to zulu from adoptopenjdk
b5ea692
@deepanchal
chore(tools): specify full version for java as asdf can't recognize it
3e13cda
@deepanchal
refactor(androidTest): replace wildcard imports with specific imports…
7f95149 
… in `CrisisCleanupAppStateTest`
@deepanchal
feat(spotless): remove copyright texts from spotless copyright files …
71c08d9 
…as its not needed at the moment
@deepanchal
feat(gradle): disable no-wildcard-imports & filename rules in ktlint
aa9d483
@deepanchal
chore: add .git-blame-ignore-revs
1da26d1
@deepanchal
ci(build): use assembleDemoDebug for build all step
5992ee6
@deepanchal
ci(build): increase timeout for build and test jobs
74fb5b3
@deepanchal
test(unit): fix coordinatesToTileCoordinates test in `TileCoordinates…
f2f8ca2 
…Test`
@deepanchal
test(unit): fix param in assertUpdatedWrongLocationFlag test in `Loca…
81b4945 
…tionInputDataFlagFormDataTest`
@deepanchal
test(unit): fix issues with AuthenticationViewModelTest
65b69bc
@deepanchal
test(unit): skip all tests in AuthenticationViewModelTest as auth f…
8f42274 
…low will have major changes in future
@deepanchal
test(unit): remove undefined import from AuthenticationViewModelTest
f308463
@deepanchal
test(unit): fix missing Locale import in CrisisCleanupAppStateTest
657a04e
@deepanchal
test(unit): add missing allowAnalytics option in `AuthenticatedViewMo…
bf4ae0d 
…delTest`
@deepanchal
ci(build): disable androidTest & androidTest-GMD jobs since packageDe…
a55f283 
…moDebugAndroidTest task is failing
@deepanchal
style(format): run `./gradlew --init-script gradle/init.gradle.kts --…
01ce3d5 
…no-configuration-cache spotlessApply` to fix spotless lint + format errors in project

Commands ran:
- ./gradlew --init-script gradle/init.gradle.kts --no-configuration-cache spotlessCheck
- ./gradlew --init-script gradle/init.gradle.kts --no-configuration-cache spotlessApply
@deepanchal
ci(build): split gradle task steps into separate jobs (build, lint, u…
7b06a6d 
…nit-test, spotless-check)
@deepanchal
ci(main): rename build.yml to main.yml, update workflow name
7444017
@deepanchal
ci(main): fix unit-test job name
71bf506
@deepanchal
ci(main): fix concurrency group name for main workflow
d9e0de7
@deepanchal deepanchal mentioned this pull request Aug 21, 2023
Closed
12 tasks
@deepanchal deepanchal changed the title ci testing feat: Setup github workflows, lint + format repo, fix unit tests Aug 21, 2023
@deepanchal deepanchal marked this pull request as ready for review August 21, 2023 20:31
hueachilles
hueachilles approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@hueachilles hueachilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@hueachilles hueachilles merged commit 1950f06 into main Aug 21, 2023
6 checks passed
@deepanchal deepanchal deleted the feat/improved-workflow-test branch August 21, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hueachilles hueachilles hueachilles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepanchal @hueachilles